check and test code and optimize some queries

app/Console/Commands/ConvertUsers.php

@@ -54,9 +54,8 @@ class ConvertUsers extends Command
     private function insertRowToUsers($data)
     {
         Database::table('users')->insertOrIgnore($data);
-       $lastUser = Database::select('SELECT * FROM `users` WHERE id=(SELECT max(id) FROM `users`)');
-
-       return $lastUser[0]->id;
+        $lastUser = Database::table('users')->orderBy('id', 'DESC')->first();
+        return $lastUser->id;
     }
 
 
@@ -156,8 +155,7 @@ class ConvertUsers extends Command
     private function categoriesConfig($categoryId, $client_id)
     {
 
-        $category = Database::select('select * from `categories` where id=? ' , [$categoryId]);
-
+        $category = Database::table('categories')->where('id' , $categoryId)->get();
 
         Database::table('wmuser_crm.client_categories')->insertOrIgnore([
             'name_en'       =>      $category[0]->name_en,
@@ -240,11 +238,12 @@ class ConvertUsers extends Command
             $this->categoriesConfig($userData->category_id, $newUserId);
             $this->InsertAddress($userAddress, $userData->id,$newUserId);
             $this->insertPhone($userData->phones , $newUserId);
-            $lastUserId = $this->insertToClientStatuses($userData->status);
-            $this->updateToUserStatus($newUserId,$lastUserId);
+            $lastStatusId = $this->insertToClientStatuses($userData->status);
+            $this->updateToUserStatus($newUserId,$lastStatusId);
             $count ++;
-            $this->info('success transfer user : '. $newUserId . '  count of add :'.$count);
 
+            $this->info('success transfer user : '. $newUserId . '  count of add : '.$count);
+            dd('success');
         }